Skip to content
This repository has been archived by the owner on Jun 12, 2024. It is now read-only.

Use the module system for bootstrapping variables #20

Open
NotAShelf opened this issue May 3, 2024 · 2 comments
Open

Use the module system for bootstrapping variables #20

NotAShelf opened this issue May 3, 2024 · 2 comments

Comments

@NotAShelf
Copy link
Contributor

The current implementation of userspace variables (system, hostname, etc...) is a common, yet not very very robust pattern. I suggest that it is advised against, and replaced with a very tiny module system inside the flake. This will not only get rid of the current solution that's going to nag the user, or worse, push them to use specialArgs for those variables but also introduce them to the module system.

I propose (and am willing to implement) replacing those examples with instances of the module system in the templates.

@isabelroses
Copy link
Member

(and am willing to implement)

If your still willing to implement this please feel free to open a PR.

@NotAShelf
Copy link
Contributor Author

Just wanted to collect comments before I made the PR, will work on the impl tomorrow.

@NotAShelf NotAShelf linked a pull request May 4, 2024 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants