chore: add codacy coverage.

auula · Sep 10, 2023 · d1e2b24 · d1e2b24
1 parent 7b889c7
commit d1e2b24
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/clog/logging.go b/clog/logging.go
@@ -72,7 +72,6 @@ func Error(v ...interface{}) {
 
 func Failed(v ...interface{}) {
 	clog.Output(2, errorPrefix+fmt.Sprint(v...))
-	os.Exit(1)
 }
 
 func Warn(v ...interface{}) {

diff --git a/server/server.go b/server/server.go
@@ -32,7 +32,7 @@ func New(opt *conf.ServerConfig) *HttpServer {
 	hs := HttpServer{
 		Server: http.Server{
 			Handler:      router.Root,
-			Addr:         fmt.Sprintf("%s:%d", IPv4, opt.Port),
+			Addr:         net.JoinHostPort(IPv4, string(opt.Port)),
 			WriteTimeout: 3 * time.Second,
 			ReadTimeout:  3 * time.Second,
 		},
@@ -54,6 +54,7 @@ func (hs *HttpServer) Startup() {
 		clog.Info("Receiving client connections")
 		if err := hs.ListenAndServe(); err != nil {
 			clog.Failed(err)
+			panic(err)
 		}
 	}()
 
@@ -66,11 +67,16 @@ func (hs *HttpServer) Startup() {
 }
 
 func (hs *HttpServer) Shutdown() {
+
 	if hs.closed == 0 {
-		clog.Failed("HTTP server not started")
+		err := "HTTP server not started"
+		clog.Failed(err)
+		panic(err)
 	}
+
 	if err := hs.Server.Shutdown(context.Background()); err != nil {
 		clog.Failed(err)
+		panic(err)
 	}
 
 	atomic.StoreInt32(&hs.closed, 1)

diff --git a/utils/string.go b/utils/string.go
@@ -2,7 +2,7 @@ package utils
 
 import "strings"
 
-// trimDaemon 从 os.Args 中移除 "-daemon" 参数
+// TrimDaemon 从 os.Args 中移除 "-daemon" 参数
 func TrimDaemon(args []string) []string {
 	var newArgs []string
 
@@ -19,6 +19,7 @@ func TrimDaemon(args []string) []string {
 	return newArgs
 }
 
+// SplitArgs 处理命令行参数以 = 分割
 func SplitArgs(args []string) []string {
 	var newArgs []string
 	// i = 1 避免处理 ./vasedb 本身