Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remapped topics for the point type migration #94

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

knzo25
Copy link
Contributor

@knzo25 knzo25 commented Jul 1, 2024

Description

The main changes are implemented and discussed in autowarefoundation/autoware.universe#6996

Remaps the velodyne_points from nebula to be used directly as pointcloud_raw_ex in autoware
Tested using the sample rosbag

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@knzo25 knzo25 requested review from drwnz and mitsudome-r July 1, 2024 00:15
Copy link
Contributor

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@knzo25 knzo25 changed the title chore: remapped topics for the point type migration chore: remapped topics for the point type migration [DO NOT MERGE] Jul 1, 2024
@knzo25 knzo25 changed the title chore: remapped topics for the point type migration [DO NOT MERGE] chore: remapped topics for the point type migration Jul 9, 2024
@knzo25 knzo25 merged commit 59843a4 into autowarefoundation:main Jul 9, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants