-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ring outlier filter and distortion correction node load from param file #6
feat: ring outlier filter and distortion correction node load from param file #6
Conversation
Signed-off-by: A. Sena Yılmaz <[email protected]>
Signed-off-by: A. Sena Yılmaz <[email protected]>
Thank you for preparing this fix.
This is with |
Signed-off-by: A. Sena Yılmaz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx, with these changes it is localizing and driving again!
Description
PR autowarefoundation/autoware.universe#8468 removes the default parameter, thus common_sensor_launch needs to load the ring outlier parameter from the parameter file.
Related links
@vividf @Ariiees @knzo25
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.