Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(autoware_multi_object_tracker): merge normal_vehicle_tracker and big_vehicle_tracker #9613

Conversation

technolojin
Copy link
Contributor

@technolojin technolojin commented Dec 11, 2024

Description

The normal_vehicle_tracker and big_vehicle_tracker has only difference of considering object size.
To remove redundant code, those are merged into one type vehicle_tracker.

This PR do not include any logic change.

Related links

Parent Issue:

  • Link

How was this PR tested?

TIER IV INTERNAL

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@technolojin technolojin self-assigned this Dec 11, 2024
@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test labels Dec 11, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@technolojin technolojin added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 29.53%. Comparing base (01944ef) to head (a0e62d8).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...ject_tracker/lib/tracker/model/vehicle_tracker.cpp 0.00% 10 Missing ⚠️
...e_multi_object_tracker/src/processor/processor.cpp 0.00% 4 Missing ⚠️
...ker/lib/tracker/model/multiple_vehicle_tracker.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9613      +/-   ##
==========================================
- Coverage   29.57%   29.53%   -0.05%     
==========================================
  Files        1442     1443       +1     
  Lines      108498   108651     +153     
  Branches    41396    41413      +17     
==========================================
  Hits        32092    32092              
- Misses      73285    73438     +153     
  Partials     3121     3121              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 29.58% <ø> (+<0.01%) ⬆️ Carriedforward from 01944ef

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@technolojin technolojin marked this pull request as ready for review December 11, 2024 09:46
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YoshiRi The change itself looks good, but I haven’t been able to check the coding style or detailed logic. Could I ask you to review those?

Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got it. Now tracker parameters are handled within object_model and vehicle tracker need only that information to switch its mode between large and normal vehicle.

LGTM

@technolojin technolojin enabled auto-merge (squash) December 12, 2024 02:29
@technolojin technolojin merged commit e30350c into autowarefoundation:main Dec 12, 2024
48 of 49 checks passed
@technolojin technolojin deleted the feat/multi-object-track/integrate-trackers branch December 12, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants