-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(autoware_multi_object_tracker): merge normal_vehicle_tracker and big_vehicle_tracker #9613
refactor(autoware_multi_object_tracker): merge normal_vehicle_tracker and big_vehicle_tracker #9613
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9613 +/- ##
==========================================
- Coverage 29.57% 29.53% -0.05%
==========================================
Files 1442 1443 +1
Lines 108498 108651 +153
Branches 41396 41413 +17
==========================================
Hits 32092 32092
- Misses 73285 73438 +153
Partials 3121 3121
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YoshiRi The change itself looks good, but I haven’t been able to check the coding style or detailed logic. Could I ask you to review those?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got it. Now tracker parameters are handled within object_model and vehicle tracker need only that information to switch its mode between large and normal vehicle.
LGTM
Description
The normal_vehicle_tracker and big_vehicle_tracker has only difference of considering object size.
To remove redundant code, those are merged into one type
vehicle_tracker
.This PR do not include any logic change.
Related links
Parent Issue:
How was this PR tested?
TIER IV INTERNAL
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.