Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(autoware_bytetrack): update visualizer param path and not to set default value #9490

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(autoware_bytetrack): update visualizer param path and not to set default value #9490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion perception/autoware_bytetrack/launch/bytetrack.launch.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<arg name="detection_rect" default="/perception/object_recognition/detection/rois0"/>
<arg name="tracked_rect" default="/perception/object_recognition/detection/tracked/rois0"/>
<arg name="bytetrack_param_path" default="$(find-pkg-share autoware_bytetrack)/config/bytetrack.param.yaml"/>
<arg name="bytetrack_visualizer_param_path" default="$(find-pkg-share autoware_bytetrack)/config/bytetrack.param.yaml"/>
<arg name="bytetrack_visualizer_param_path" default="$(find-pkg-share autoware_bytetrack)/config/bytetrack_visualizer.param.yaml"/>
<arg name="enable_visualizer" default="true"/>

<node pkg="autoware_bytetrack" exec="bytetrack_node_exe" output="screen">
Expand Down
2 changes: 1 addition & 1 deletion perception/autoware_bytetrack/src/bytetrack_visualizer_node.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
{
using std::chrono_literals::operator""ms;

use_raw_ = declare_parameter("use_raw", false);
use_raw_ = declare_parameter<bool>("use_raw");

Check warning on line 37 in perception/autoware_bytetrack/src/bytetrack_visualizer_node.cpp

View check run for this annotation

Codecov / codecov/patch

perception/autoware_bytetrack/src/bytetrack_visualizer_node.cpp#L37 

Added line #L37 was not covered by tests

// Create timer to find proper settings for subscribed topics
timer_ = rclcpp::create_timer(
Expand Down
Loading