-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gnss_poser): subscribe map projector info #4791
feat(gnss_poser): subscribe map projector info #4791
Conversation
Signed-off-by: kminoda <[email protected]>
Signed-off-by: kminoda <[email protected]>
Signed-off-by: kminoda <[email protected]>
Signed-off-by: kminoda <[email protected]>
Signed-off-by: kminoda <[email protected]>
Signed-off-by: kminoda <[email protected]>
Signed-off-by: kminoda <[email protected]>
Signed-off-by: kminoda <[email protected]>
Signed-off-by: kminoda <[email protected]>
Signed-off-by: kminoda <[email protected]>
Signed-off-by: kminoda <[email protected]>
ec7a5e4
to
2d7c420
Compare
Signed-off-by: kminoda <[email protected]>
Signed-off-by: kminoda <[email protected]>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4791 +/- ##
==========================================
+ Coverage 15.11% 15.14% +0.02%
==========================================
Files 1573 1567 -6
Lines 108378 107795 -583
Branches 33284 32999 -285
==========================================
- Hits 16385 16329 -56
+ Misses 74138 73682 -456
+ Partials 17855 17784 -71
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: kminoda <[email protected]>
Signed-off-by: kminoda <[email protected]>
Signed-off-by: kminoda <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
please merge this pr after merging #4850
Description
Use /map/map_projector_info in gnss_poser
Related links
Tests performed
ros2 topic info -v /map/map_projector_info
is as followNotes for reviewers
None
Interface changes
None
Effects on system behavior
The output of gnss_poser will now going to depend on the map projector info defined in map_projection_loader.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.