From 5b5a93c92a1cc46680ece34bd4e8ebbb94cbb60e Mon Sep 17 00:00:00 2001 From: Ryuta Kambe Date: Wed, 27 Nov 2024 09:28:57 +0900 Subject: [PATCH] fix(autoware_pointcloud_preprocessor): fix clang-diagnostic-inconsistent-missing-override (#9445) Signed-off-by: veqcc --- .../crop_box_filter/crop_box_filter_node.hpp | 4 ++-- .../outlier_filter/ring_outlier_filter_node.hpp | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/sensing/autoware_pointcloud_preprocessor/include/autoware/pointcloud_preprocessor/crop_box_filter/crop_box_filter_node.hpp b/sensing/autoware_pointcloud_preprocessor/include/autoware/pointcloud_preprocessor/crop_box_filter/crop_box_filter_node.hpp index 2a983835e4e55..2eb0f2505642a 100644 --- a/sensing/autoware_pointcloud_preprocessor/include/autoware/pointcloud_preprocessor/crop_box_filter/crop_box_filter_node.hpp +++ b/sensing/autoware_pointcloud_preprocessor/include/autoware/pointcloud_preprocessor/crop_box_filter/crop_box_filter_node.hpp @@ -67,8 +67,8 @@ namespace autoware::pointcloud_preprocessor class CropBoxFilterComponent : public autoware::pointcloud_preprocessor::Filter { protected: - virtual void filter( - const PointCloud2ConstPtr & input, const IndicesPtr & indices, PointCloud2 & output); + void filter( + const PointCloud2ConstPtr & input, const IndicesPtr & indices, PointCloud2 & output) override; // TODO(sykwer): Temporary Implementation: Remove this interface when all the filter nodes conform // to new API diff --git a/sensing/autoware_pointcloud_preprocessor/include/autoware/pointcloud_preprocessor/outlier_filter/ring_outlier_filter_node.hpp b/sensing/autoware_pointcloud_preprocessor/include/autoware/pointcloud_preprocessor/outlier_filter/ring_outlier_filter_node.hpp index a19c0c1e257b2..c898cbacf33ea 100644 --- a/sensing/autoware_pointcloud_preprocessor/include/autoware/pointcloud_preprocessor/outlier_filter/ring_outlier_filter_node.hpp +++ b/sensing/autoware_pointcloud_preprocessor/include/autoware/pointcloud_preprocessor/outlier_filter/ring_outlier_filter_node.hpp @@ -44,8 +44,8 @@ class RingOutlierFilterComponent : public autoware::pointcloud_preprocessor::Fil using InputPointType = autoware::point_types::PointXYZIRCAEDT; using OutputPointType = autoware::point_types::PointXYZIRC; - virtual void filter( - const PointCloud2ConstPtr & input, const IndicesPtr & indices, PointCloud2 & output); + void filter( + const PointCloud2ConstPtr & input, const IndicesPtr & indices, PointCloud2 & output) override; // TODO(sykwer): Temporary Implementation: Remove this interface when all the filter nodes conform // to new API