Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Analyze.best_params as dictionary #502

Open
rlleshi opened this issue Sep 2, 2020 · 3 comments
Open

Return Analyze.best_params as dictionary #502

rlleshi opened this issue Sep 2, 2020 · 3 comments
Assignees
Labels
priority: MEDIUM medium priority topic: experience Having to do with researcher/developer experience. value: ⭐ low value

Comments

@rlleshi
Copy link

rlleshi commented Sep 2, 2020

Currently Reporting.best_params will return an array containing the best parameter values. However, it will not return the corresponding parameter names and this makes it difficult to tell apart which value stands for which parameter.

1) I think Talos should add

In commands/analyze.py, I think it would be better if best_params returned the complete dataframe (out) instead of the values (out.values)

2) Once implemented, I can see how this feature will

It will be easier to understand which values correspond to which parameters

3) I believe this feature is

nice to have

4) Given the chance, I'd be happy to make a PR for this feature

definitely


@github-actions
Copy link

github-actions bot commented Sep 2, 2020

Welcome to Talos community! Thanks so much for creating your first issue :)

@mikkokotila mikkokotila self-assigned this Nov 9, 2020
@mikkokotila mikkokotila added value: ⭐ low value topic: experience Having to do with researcher/developer experience. labels Nov 9, 2020
@mikkokotila mikkokotila changed the title Reporting.best_params returns the attributes list as well Return Analyze.best_params as dictionary Nov 15, 2020
@mikkokotila mikkokotila added the priority: MEDIUM medium priority label Nov 15, 2020
@mikkokotila
Copy link
Contributor

I think best make it into a dictionary. The goal here is to be able to feed back to the experiment programmatically.

@NA-Dev
Copy link

NA-Dev commented Mar 20, 2021

I second this. I have no idea how to read my best_params output. Documentation also needs to be added for the parameters of best_params(). exclude is required, but I don't know what it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: MEDIUM medium priority topic: experience Having to do with researcher/developer experience. value: ⭐ low value
Projects
None yet
Development

No branches or pull requests

3 participants