Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added -k flag to curl #9

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Added -k flag to curl #9

wants to merge 3 commits into from

Conversation

sintrode
Copy link

@sintrode sintrode commented Dec 1, 2022

Added flag to allow insecure curl connections for edge case where certain antivirus software does not allow them otherwise. Also shortened Runtime search string to resolve #8

Added flag to allow insecure curl connections for edge case where certain antivirus software does not allow them otherwise. Also shortened Runtime search string to resolve automuteus#8
@denverquane
Copy link
Contributor

denverquane commented Dec 2, 2022

I'm happy you were able to find a solution for your situation, and I'll leave the PR up so others can see or improve upon it. But as a matter of policy, I don't think merging PRs that unilaterally decrease security for all users is a good idea

@sintrode
Copy link
Author

sintrode commented Dec 2, 2022

That's understandable. I suppose I could go in the opposite direction and convert the curl commands that are giving me trouble to powershell -command "Invoke-WebRequest" commands instead.

What's the earliest version of Windows that the bot needs to support? As of Windows 10, VT100 sequences are enabled so the :colorEcho section is no longer necessary; I would like to do some additional rewrites if possible.

Eliminated need for PowerShell entirely; took advantage of Windows 10 features such as curl, tar, and VT100 sequences; redesigned progress display
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants