-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker resource limits for jobs #241
Conversation
Warning Rate Limit Exceeded@evanyeyeye has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 27 minutes and 2 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent updates involve enhancing resource management for Docker containers in an autograding system. The changes allow for dynamic allocation of CPU cores and memory limits based on configurations or job-specific requirements. This is achieved by modifying method signatures to accept resource parameters and updating the logic to apply these constraints when creating and running Docker containers. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified that limits are set (1GB memory, 1 CPU):
(Ref https://phoenixnap.com/kb/docker-memory-and-cpu-limit)
However, need to avoid breaking existing installations -- see comment about getattr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified that autograding works when Config.py
is outdated
LGTM
Adds the following resource limits to new jobs:
Addresses: @139
Resource limits can be verified using
docker stats
andhtop
.