Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint devise, components, course_mailer, device_flow_activation #1968

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Lint devise, components, course_mailer, device_flow_activation #1968

merged 1 commit into from
Sep 12, 2023

Conversation

20wildmanj
Copy link
Contributor

Summary

reviewpad:summary

Description

  • Linted views/course_mailer (no changes needed so nothing here), views/components, views/device_flow_activation, views/devise using erblint using bundle exec erblint app/views/*(folder)/*(file).html.erb -a

Motivation and Context

  • As part of summer linting

How Has This Been Tested?

  • Check that edit password looks fine (under Account -> Change Password)
  • Sign Up form looks fine
  • Sign In page looks fine
  • Registration / Forgot your password / Didn't receive confirmation instructions? looks fine

Things not broken

Checklist:

  • I have run rubocop for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting
  • My change requires a change to the documentation, which is located at Autolab Docs
  • I have updated the documentation accordingly, included in this PR

@reviewpad reviewpad bot requested a review from najclark August 24, 2023 00:36
@reviewpad reviewpad bot added medium Pull request is medium waiting-for-review labels Aug 24, 2023
najclark
najclark approved these changes Sep 10, 2023
View reviewed changes
Copy link
Contributor

@najclark najclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@20wildmanj 20wildmanj added this pull request to the merge queue Sep 12, 2023
Merged via the queue into master with commit 10e5d66 Sep 12, 2023
6 checks passed
@20wildmanj 20wildmanj deleted the joeywildman-lint-components-coursemailer-deviceflowactivation branch September 12, 2023 16:15
NicholasMy pushed a commit to UB-CSE-IT/Autolab that referenced this pull request Jan 4, 2024
@20wildmanj @NicholasMy
Lint devise, components, course_mailer, device_flow_activation (autol…
df54fff 
…ab#1968)

lint devise, components, device_flow_activation

(cherry picked from commit 10e5d66)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@najclark najclark najclark approved these changes

Assignees
No one assigned
Labels
medium Pull request is medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@20wildmanj @najclark