Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to specify the versions? #1

Open
houmie opened this issue Nov 7, 2014 · 2 comments
Open

How to specify the versions? #1

houmie opened this issue Nov 7, 2014 · 2 comments

Comments

@houmie
Copy link

houmie commented Nov 7, 2014

It seems it doesn't support the latest 1.9.15 yet.

I wonder if the code could be adjusted to pass in the required version number.

Thanks,

@peterhudec
Copy link
Member

@houmie,
Sorry for the delayed response, I never get notifications about new issues although I'm watching the repo.

It could be technically possible to resolve the SDK zip dynamically by the version number, but I this could open a security hole. Currently the downloaded zip is checked against a hardcoded SHA1 checksum.

I have considered to create a web service which would check whether there's a new GAE SDK version and then automatically commit a new version and notify subscribers, but this solution seems to suffer with the same security issue and would probably be very fragile.

But maybe my security misgivings are unjustified. What do you think?

@houmie
Copy link
Author

houmie commented Dec 15, 2014

I see your point. I think its best to keep it simple. At the end developers are using this. Maybe you allow a version to be set by passing in the SHA1 checksum + version number, hence keeping it dynamic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants