Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for encoding option to jws.decode, and fix forwarding of … #106

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

loucadufault
Copy link

Description

(trivially) Adds support for encoding option to jws.decode API by passing this encoding from opts to payloadFromJWS. Also, fixes the broken encoding option currently documented for the jws.createVerify API, by properly passing the encoding option to be wrapped in an object passed to implementation call to decode.

This change should make this option functional for both these APIs.

References

Largely the same code change as proposed in #86, with change to remove passing of encoding option to JSON.parse as this is ignored, and properly forward option from VerifyStream.proto.verify method (and fix conflicts and clean history).

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@glensc
Copy link

glensc commented Feb 6, 2023

The removal of wrong use of reviver parameter also in this PR:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants