Add support for encoding option to jws.decode, and fix forwarding of … #106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(trivially) Adds support for
encoding
option tojws.decode
API by passing this encoding fromopts
topayloadFromJWS
. Also, fixes the brokenencoding
option currently documented for thejws.createVerify
API, by properly passing theencoding
option to be wrapped in an object passed to implementation call todecode
.This change should make this option functional for both these APIs.
References
Largely the same code change as proposed in #86, with change to remove passing of encoding option to
JSON.parse
as this is ignored, and properly forward option fromVerifyStream.proto.verify
method (and fix conflicts and clean history).Testing
Checklist