Use burner-core for token balances #223
Conversation
dmihal
force-pushed
the
burner-core-tokens
branch
2 times, most recently
from
d037b1d to
22de168
Compare
|
Updated this to use the newest packages, and rebased to the recent changes with burner-core |
dmihal
force-pushed
the
burner-core-tokens
branch
2 times, most recently
from
78a95b2 to
42650ba
Compare
| @@ -23,6 +24,9 @@ if (process.env.REACT_APP_MODE === 'local') { | |||
| } | |||
|
|
|||
| const assets = [mainAsset, dai, eth]; | |||
| if (token) { | |||
| assets.unshift(token); | |||
There was a problem hiding this comment.
Mind elaborating what this does?
There was a problem hiding this comment.
Assets is an array of all tokens/coins we will display in the app. If the token variable is set here, then we want to add that to the array so we can display it in the list of tokens.
There was a problem hiding this comment.
OK, I believe a comment would clear that up nicely. But up to you.
There was a problem hiding this comment.
Actually let's merge it and comment it later.
dmihal
force-pushed
the
burner-core-tokens
branch
from
42650ba to
8273d41
Compare
dmihal
force-pushed
the
burner-core-tokens
branch
from
8273d41 to
7f6aa5a
Compare
|
Thanks for the review @TimDaub, you caught some good issues! I've addressed all the issues. This PR hasn't actually been tested on a token in a bit, I'll try to do a local test soon. |
OK let me know how it goes and feel free to merge after testing! Thx |
PR #211 integrated burner-core for reading the main 3 assets (xDai, Dai and Eth), this PR expands on that by using burner-core to read the balance of an additional token.
The largest impact on the codebase is the removal of the ERC20TOKEN and ERC20VENDOR variables, replacing them with data from assets.js, as well as hardcoded contract names.