Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create continuous integration #228

Open
johannbarbie opened this issue Jun 13, 2019 · 4 comments
Open

create continuous integration #228

johannbarbie opened this issue Jun 13, 2019 · 4 comments
Labels
bounty size-S total effort of ~350 DAI
Milestone

Comments

@johannbarbie
Copy link
Collaborator

johannbarbie commented Jun 13, 2019

Scope

  • have a commit hook that runs tests
  • have a commit hook that runs linter

Deliverables

  • working .yml file
  • ???

Roles

bounty gardener: name / 10% - 30%
bounty worker: name / 50% - 80%
bounty reviewer: name / 10% - 30%

@johannbarbie johannbarbie added bounty size-S total effort of ~350 DAI labels Jun 13, 2019
@johannbarbie johannbarbie added this to the Sprint 1 milestone Jun 13, 2019
@troggy
Copy link
Contributor

troggy commented Jun 13, 2019

dibs :)

@johannbarbie
Copy link
Collaborator Author

@troggy for gardener and worker? :)
the issue is missing some details, and a proper allocation of shares.

@troggy
Copy link
Contributor

troggy commented Jun 13, 2019

worker :) Done similar thing in our repo already

@djudjuu
Copy link

djudjuu commented Jul 8, 2019

Hey @johannbarbie, @troggy so i tried this in my own fork (authorizing travis.ci requires repo ownership), but when building the project in the travis VM, there are a bunch of errors that I dont understand but maybe they mean something to you: https://travis-ci.com/djudjuu/burner-wallet/builds/118305462

Also, can you confirm these other assumptions of mine?

  • the test to be run is "clevis test full" (or maybe just the "npm run test")
  • to set the project up in the travis VM, I need to run npx clevis init
    -> which could get tricky as there is no one to press ENTER a bunch of times (or is there a way we can readily adjust that command to work anyways...)

===================
Also I added the standard-js linter to the pipeline and it (expectedly creates a bunch of errors), so maybe it would be worthwhile to further specify

  • a) whether you agree to using standard-js
  • b) which files should be linted/exluded
  • c) if you also want a solidity-linter (solhint)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty size-S total effort of ~350 DAI
Projects
None yet
Development

No branches or pull requests

3 participants