Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous deployment for xdai.io #203

Open
TimDaub opened this issue Jun 4, 2019 · 1 comment
Open

Continuous deployment for xdai.io #203

TimDaub opened this issue Jun 4, 2019 · 1 comment
Labels
bounty enhancement New feature or request size-S total effort of ~350 DAI
Milestone

Comments

@TimDaub
Copy link
Collaborator

TimDaub commented Jun 4, 2019

Scope

  • Currently the burner wallet relies on @austintgriffith to be deployed to e.g. xdai.io.
  • As we'd like to ship to production as often as possible, having continuous integration would be nice.
  • The LeapDAO team has already done this with their burner, so we could just copy what they're doing: chore: add travis CI config leapdao/plasma-burner-wallet#144
  • Note that we might not want to deploy everything in master directly into production. As the code base is handling actual people's money, I'd propose we do as following:
    • Have a branch that deploys a burner-wallet to test.xdai.io with e.g. Rinkeby support (maybe that's master). Pro-tip for making Exchange.js work on Rinkeby: Uniswap has contracts deployed on Rinkeby
    • Have a branch that deploys to xdai.io (e.g. "production")

Deliverables

  • Implement continuous deployment for the burner-wallet, a staging domain and a production domain
  • Remove the now outdated scripts used for deployment

Notes

Roles

bounty gardener: @TimDaub / 10%
bounty worker: name / 75%
bounty reviewer: name / 15%

@TimDaub TimDaub added the enhancement New feature or request label Jun 4, 2019
@TimDaub TimDaub added this to the Sprint 1 milestone Jun 4, 2019
@dmihal
Copy link
Collaborator

dmihal commented Jun 4, 2019

This is related to #208, regarding which branch is used for what.

My suggestion would be master is for production, and we have staging and develop as well with their own deployments as well.

I'd also suggest each PR gets an automatic "review app" deployed, assuming there's funding for that many instances.

@johannbarbie johannbarbie added bounty size-S total effort of ~350 DAI labels Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty enhancement New feature or request size-S total effort of ~350 DAI
Projects
None yet
Development

No branches or pull requests

3 participants