Generates cards stats after payment step #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/L
Codecov Report
@@ Coverage Diff @@
## master #170 +/- ##
==========================================
+ Coverage 75.10% 75.15% +0.05%
==========================================
Files 67 67
Lines 1928 1932 +4
Branches 272 272
==========================================
+ Hits 1448 1452 +4
Misses 400 400
Partials 80 80
Continue to review full report at Codecov.
|
austinpray
commented
Jul 4, 2020
|
|
||
| return u | ||
|
|
||
| return make_user | ||
|
|
||
|
|
||
| @pytest.fixture() | ||
| def grant_kkreds(test_db: DB) -> callable: |
There was a problem hiding this comment.
will be useful to testing payment later
| session.add(u) | ||
| session.commit() | ||
| user_id = u.id | ||
| # grant_kkreds(u, 1e10) |
There was a problem hiding this comment.
when I make S-tier cards this test will fail until this is uncommented
|
I split the UI changes into #172 |
ridhoq
approved these changes
Jul 5, 2020
pull-request-size
bot
added
size/M
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #168
before
This is a problem: if you don't like the stats, why not just abandon the card and try recreating until you get stats you like? You need to pay to publish a card
after
Now you are stuck with that card's stats.
ui changessplit into #172