Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gsim doesn't work in non-tty environments #65

Open
2 tasks
austinpray opened this issue May 31, 2020 · 0 comments
Open
2 tasks

gsim doesn't work in non-tty environments #65

austinpray opened this issue May 31, 2020 · 0 comments
Assignees
Labels
bug feature/gacha needs-priority Indicates a PR lacks a `priority/foo` label and requires one.

Comments

@austinpray
Copy link
Owner

austinpray commented May 31, 2020

table output

TTY:

dcr gsim battle jules ubu
# works as expected with pretty output

Non-TTY:

dcr gsim battle jules ubu | tee $(mktemp)
# blank output and clears my terminal

image

Note the !! Could not derive your terminal width !! in non-TTY environments

web and web_raw format

TTY works fine:

dcr gsim battle -f web_raw jules ubu
# {"a":{"id":1,"name":"Jules","image_url":"https:\/\/storage.googleapis.com\/img.kaori.io\/static\/img\/jules.png","rarity":"A","nature":"horny and feral","stupid":1,"baby":1,"clown":2,"horny":8,"cursed":1,"feral":7,"max_hp" ...

non-TTY has broken output

dcr gsim battle -f web_raw jules ubu | tee $(mktemp)
# !! Could not derive your terminal width !!
# {"a":{"id":1,"name":"Jules","image_url":"https:\/\/s

Note the !! Could not derive your terminal width !! in non-TTY environments

action

  • the default gsim command should work in non-TTY environments. This is blocking e2e tests of gsim
  • pretty output should be disabled for non-TTY environments. web and web_raw format don't need a TTY so that code path should not even be touched
@austinpray austinpray added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/gacha needs-priority Indicates a PR lacks a `priority/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

2 participants