feat: Sync skip delete #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkc
approved these changes
Oct 22, 2024
gkc
requested changes
Oct 22, 2024
packages/at_commons/pubspec.yaml
Outdated
| @@ -1,6 +1,6 @@ | |||
| name: at_commons | |||
| description: A library of Dart and Flutter utility classes that are used across other components of the atPlatform. | |||
| version: 5.0.1 | |||
| version: 5.0.2 | |||
There was a problem hiding this comment.
should be 5.1.0 as this is new feature
gkc
reviewed
Dec 2, 2024
packages/at_commons/CHANGELOG.md
Outdated
| @@ -1,3 +1,5 @@ | |||
| ## 5.1.0 | |||
| - feat: Introduce skipDeletes for sync:from verb | |||
gkc
requested changes
Dec 2, 2024
| @@ -9,6 +9,8 @@ class SyncVerbBuilder implements VerbBuilder { | |||
|
|
|||
| bool isPaginated = false; | |||
|
|
|||
| int? skipDeletesUntil; | |||
There was a problem hiding this comment.
Please take this opportunity to add /// documentation for all of the parameters (commitId, regex, limit, isPaginated, skipDeletesUntil)
gkc
approved these changes
Dec 2, 2024
packages/at_commons/CHANGELOG.md
Outdated
| @@ -1,3 +1,5 @@ | |||
| ## 5.1.0 | |||
| - feat: Introduce skipDeletes for sync:from verb | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it