Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AtSigningAlgo and AtHashingAlgo data set in OnboardingCli not reaching AtAuth #602

Open
srieteja opened this issue Jun 27, 2024 · 1 comment · May be fixed by #608
Open

AtSigningAlgo and AtHashingAlgo data set in OnboardingCli not reaching AtAuth #602

srieteja opened this issue Jun 27, 2024 · 1 comment · May be fixed by #608
Assignees
Labels
bug Something isn't working

Comments

@srieteja
Copy link
Contributor

srieteja commented Jun 27, 2024

Describe the bug

Although AtOnboardingPreference takes AtSigningAlgo and AtHashingAlgo as optional inputs. There is no way as of now to pass that same data to AtAuth. This causes AtAuth to perform Auth using the default values for Signing and Hashing algo.

Steps to reproduce

  1. Create an instance of AtOnboardingCli, where the AtOnboardingPreference mentions AtSigningAlgo to be 'ecc_secp256r1'
  2. In the above step, ensure to pass ecc type Public and Private keys for pkam/apkam authentication
  3. Set the AtSignLogger root level to FINER
  4. Call AtOnboardingService.authenticate()
  5. PKAM authentication fails
  6. On finding the command that is sent to perform pkam authentication, the command would still mention that AtSigningAlgo is RSA.

Expected behavior

The pkam authentication command should specify whichever SigningAlgo mentioned in the AtOnboardingPreferences

Additional context

One possible solution could be adding new params for AtSigningAlgo and AtHashingAlgo in AtOnboardingRequest, which is used to pass params from AtOnboardingCli to AtAuth.

@srieteja srieteja added the bug Something isn't working label Jun 27, 2024
@srieteja srieteja self-assigned this Jun 27, 2024
@srieteja
Copy link
Contributor Author

srieteja commented Aug 5, 2024

Blocked by atsign-foundation/at_server#2045. Requires the mentioned issue to be fixed for the functional tests to pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant