Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate shared code of onboarding flutter and onboarding cli to a new package. #468

Open
7 of 9 tasks
sitaram-kalluri opened this issue Dec 2, 2023 · 4 comments · May be fixed by #508
Open
7 of 9 tasks

Consolidate shared code of onboarding flutter and onboarding cli to a new package. #468

sitaram-kalluri opened this issue Dec 2, 2023 · 4 comments · May be fixed by #508
Assignees
@srieteja

Comments

@sitaram-kalluri
Copy link
Member

sitaram-kalluri commented Dec 2, 2023 •
edited by srieteja
Loading

Is your feature request related to a problem?

Currently, there is redundancy in the onboarding code between the onboarding Flutter and onboarding CLI. To enhance maintainability, relocate the common code to a new package.

Progress Tracker:

  • Create a new package and move relevant code into it
  • Modify/optimize package design (so that register_cli and onboarding_flutter can both consume it without issues)
  • In-code docs
  • unit tests
  • Manual testing
  • docs (readme, changelog, etc)
  • Inclusion of this package and its tests into GitHub actions
  • Integration testing (testing apps/cli's functioning with this package as dependency_override)
  • Publish to pub.dev
@murali-shris
Copy link
Member

murali-shris commented Dec 4, 2023 •
edited
Loading

Registrar related code:

  • onboarding_cli/register_cli.dart

    • get free atsigns /v3/get-free-atsign/
    • register atsign /v3/register-person
    • validate otp /v3/validate-person

  • onboarding_cli/onboarding_util.dart

    • getCramUsingOtp /v3/authenticate/atsign
    • getCramKey /v3/authenticate/atsign/activate

  • at_onboarding_flutter/free_atsign_service.dart

    • get free signs /v2/get-free-atsign
    • authenticate /v2/login/atsign
    • register atsign /v2/register-person
    • validate atsign /v2/validate-person
    • verify atsign /v2/login/atsign/validate

@srieteja
Copy link
Contributor

srieteja commented Jan 8, 2024

Common code has been moved to a new package "at_register" [not updated to git yet]. Testing integration with register_cli and the onboarding_flutter.

@srieteja srieteja mentioned this issue Feb 20, 2024
Open
@srieteja
Copy link
Contributor

srieteja commented Mar 4, 2024

Implementation of the new AtRegister package has been completed and is currently being tracked in #508. Assigning 1 sprint point to handle any changes required as part of pr review.

@srieteja srieteja linked a pull request Mar 14, 2024 that will close this issue
Draft
@srieteja
Copy link
Contributor

srieteja commented Oct 8, 2024

The impl for this ticket has been in #508 for some time. Will take this up and bring this to speed once I have capacity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srieteja srieteja

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: introduce a new 'register' package with consolidated code atsign-foundation/at_libraries
3 participants
@sitaram-kalluri @murali-shris @srieteja