Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move over to Other Templating Engine (pkl ideally) #68

Closed
tulilirockz opened this issue Mar 25, 2024 · 8 comments
Closed

chore: move over to Other Templating Engine (pkl ideally) #68

tulilirockz opened this issue Mar 25, 2024 · 8 comments
Assignees

Comments

@tulilirockz
Copy link
Collaborator

Containerfiles are better for this project because it would be easier to contribute to, and having less abstrations makes it so knowing what the hell is in the image a lot easier, and we wouldnt need the jsonnet -> yaml/bluebuild -> containerfile dynamic.

@fiftydinar
Copy link
Contributor

:(

@fiftydinar
Copy link
Contributor

fiftydinar commented Mar 26, 2024

I'm interested to know how would Containerfile look at the end, to see what is the difference in implementation & structure.

I thought about doing this for Bluefin in a opposite way, which is possible imo, but Bluefin is not something I use daily, so I scratched that.

@tulilirockz tulilirockz moved this to In Progress in Project Roadmap Mar 27, 2024
@tulilirockz tulilirockz moved this from In Progress to Todo in Project Roadmap Mar 27, 2024
@xynydev
Copy link
Contributor

xynydev commented Apr 2, 2024

I assume the structure would look more like ubluemain or bluefin. IMO this is refactor: though.

Also keep in mind that you can keep using BlueBuild modules for stuff like Flatpaks if you decide to refactor, I can walk you through that if that's desireable.

We're of course also interested in specific frustrations you've had with BB (even if you believe that they can't be fixed) and what you hope to gain from a refactor.

I find this project pretty interesting as a creative myself, so I have taken a good look at the source code and config, and do have some thoughts on how I'd refactor it within the system.

@tulilirockz
Copy link
Collaborator Author

tulilirockz commented Apr 4, 2024

Honestly using bluebuild has been amazing! The only thing is that there are multiple layers of abstraction and that makes it so that refactoring stuff is a tiny bit confusing Im thinking about just moving everything over to apple pkl (including the modules) so that it might have a bit less layers that we need to work with (jsonnet + yaml -> containerfile vs pkl -> yml -> containerfile)

@xynydev
Copy link
Contributor

xynydev commented Apr 4, 2024

If you get pkl working, let me know. I've been trying a bunch of stuff here, but haven't tried pkl yet due to finding the docs kind of hard to read, not finding the info I'm looking for, etc.

@tulilirockz
Copy link
Collaborator Author

Pkl is pretty nice! Implemented stuff with b67f8c6. 👍

@github-project-automation github-project-automation bot moved this from Todo to Done in Project Roadmap Apr 28, 2024
@xynydev
Copy link
Contributor

xynydev commented Apr 28, 2024

Isn't this "not planned", and not "completed"?

@tulilirockz
Copy link
Collaborator Author

Well, true! I guess this issue was just for moving to something other that raw yaml files

@tulilirockz tulilirockz changed the title chore: move over to Containerfile chore: move over to Other Templating Engine (pkl ideally) Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants