Improve write bundles performance #107
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #72 added a feature-flag to switch to the new LMDB back-end, however that flag isn't correctly read because it is not set when resolving options. This PR changes the feature-flags code to set feature-flags before anything else. AFB-786
…undles-performance
yamadapc
commented
Oct 8, 2024
yamadapc
commented
Oct 8, 2024
yamadapc
commented
Oct 8, 2024
JakeLane
approved these changes
Oct 14, 2024
…undles-performance
…atlassian-labs/atlaspack into issue/improve-write-bundles-performance
…undles-performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves write bundles performance by rewriting hash_ref replacement in rust.
Removes streaming from this part of the code since the bundles aren't huge and most of the time they were loaded in memory already. This should reduce the memory footprint due to avoiding copies caused by piping into paused streams.
Performance should be at least 5x better, hopefully the memory usage drop will result in a reasonable improvement on overall build times.