Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception thrown if no data updated #6

Open
ElGigi opened this issue Jun 25, 2019 · 0 comments
Open

Exception thrown if no data updated #6

ElGigi opened this issue Jun 25, 2019 · 0 comments

Comments

@ElGigi
Copy link

ElGigi commented Jun 25, 2019

throw Exception::unexpectedRowCountAffected($rowCount);

Why thrown an exception if no data updated in a record?
If original record it's the same as persisted record, it's more judicious to do not perform an update instead thrown an exception.

Especially since this is a problem when you save changes only in child records.
Cf: atlasphp/Atlas.Transit#17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant