Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work on mobile #1

Open
PacoBell opened this issue Jan 22, 2017 · 2 comments
Open

Does not work on mobile #1

PacoBell opened this issue Jan 22, 2017 · 2 comments
Labels

Comments

@PacoBell
Copy link

AFAIK, Firefox for Android does not have any concept of a "toolbar", so your add-on is ineffective here. It seems that you need to present your button as a "page action" instead of a "browser action" for it to be visible on mobile. Also, your extension's "options page" doesn't seem to display anything but a blank. I used this Mozilla page as a reference:

https://developer.mozilla.org/en-US/Add-ons/WebExtensions/Anatomy_of_a_WebExtension

@athos-ribeiro
Copy link
Owner

Firefox WebExtensions do not support chrome.proxy API yet, but they are working on it ATM [1]. I was waiting for it to be available to fully rewrite this add-on, considering the Android support.

Just for the records, we have two different issues here:

  • The add-on does not work in the Andriod version, since it does not display an option to have the settings turned on/off.
  • The other problem is that we have a blank options page.

I will go on and start porting it to WebExtensions, even without the proxy API support. As soon as the API is available, I will consider building the extension for other browsers as well.

Also, feel free to submit patches, if you have them or wish to contribute. Thank you for taking the time to report the issue and providing links with solutions. :)

[1] http://stackoverflow.com/questions/40183372/chrome-proxy-api-for-firefox-webextensions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants