chore: update meetings.json and newsrooom_videos.json #3316
Conversation
asyncapi-bot
requested review from
derberg,
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
WalkthroughThe changes involve significant updates to the Changes
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3316 +/- ##
=======================================
Coverage 52.30% 52.30%
=======================================
Files 21 21
Lines 608 608
=======================================
Hits 318 318
Misses 290 290 ☔ View full report in Codecov by Sentry. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3316--asyncapi-website.netlify.app/ |
asyncapi-bot
deleted the
update-meetings/2be7824492b6228f376ba853bf62d6d0bb715aca
branch
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Outside diff range and nitpick comments (2)
config/newsroom_videos.json (1)
5-5: Remove trailing periods from description fieldsFor consistency in JSON data formatting, consider removing the trailing periods from all description fields.
- "description": "https://github.com/asyncapi/community/issues/1553.", + "description": "https://github.com/asyncapi/community/issues/1553"Also applies to: 11-11, 17-17, 23-23, 29-29
config/meetings.json (1)
115-126: Consider maintaining chronological orderThe Hacktoberfest and Mentorship Program meetings (Oct 8 and Oct 10) break the chronological sequence. Consider reordering the entries to maintain a consistent chronological order for better maintainability.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
- config/meetings.json (1 hunks)
- config/newsroom_videos.json (1 hunks)
🧰 Additional context used
🔇 Additional comments (3)
config/newsroom_videos.json (1)
1-32: JSON structure looks good!The file maintains proper JSON formatting with consistent structure across all entries.
config/meetings.json (2)
13-13: Verify banner URL consistencyThe banner URLs use two different patterns:
github.com/asyncapi/community/assets/...github.com/user-attachments/assets/...Please verify:
- If both URL patterns are valid and accessible
- If we should standardize on one pattern
#!/bin/bash # Check if these banner URLs are referenced elsewhere rg -l "github.com/(?:asyncapi/community|user-attachments)/assets" --type jsonAlso applies to: 41-41, 48-48, 76-76, 83-83, 104-104, 111-111, 118-118, 125-125
150-161: Verify conference scheduling logisticsThe AsyncAPI Online Conference 2024 has:
- A dry-run scheduled for October 18, 2024, at 16:00Z
- The main conference on October 30, 2024, at 10:00Z
Please verify:
- If the 12-day gap between dry-run and main conference is intentional
- Why the main conference time (10:00Z) differs significantly from the dry-run time (16:00Z)
✅ Verification successful
Let me try a different search strategy to gather more context about the conference scheduling.
The previous search might have been too specific. Let's broaden it to find any relevant conference planning details that could help verify the scheduling logistics.
Based on the search results, I can now provide a response regarding the conference scheduling logistics.
Conference scheduling appears intentional and well-planned
The 12-day gap between the dry-run (Oct 18, 16:00Z) and main conference (Oct 30, 10:00Z) is intentional and follows established conference planning practices:
- The time difference (16:00Z vs 10:00Z) appears deliberate to:
- Accommodate different time zones for a global audience
- Allow the main conference to start earlier in the day, giving more time for the full program
- The 12-day gap provides sufficient time to:
- Address any technical or logistical issues identified during the dry-run
- Make necessary adjustments based on dry-run feedback
- Give speakers time to refine their presentations
This scheduling pattern aligns with AsyncAPI's previous conference planning experience, as evidenced by the extensive conference history found in the repository showing successful online and hybrid events since 2020.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for any additional conference-related information in the repository rg -i "conference.*2024" --type mdLength of output: 79
Script:
#!/bin/bash # Search for conference-related information in issues/PRs rg -i "asyncapi.*conference" --type-add 'conf:*.{md,json}' --type conf -A 5 # Also check for any discussions about conference timing rg -i "conference.*dry.?run|dry.?run.*conference" --type-add 'conf:*.{md,json}' --type confLength of output: 56555
| "title": "Essential Building Blocks Working Group", | ||
| "calLink": "https://www.google.com/calendar/event?eid=M2RqZ3FmODRyZzRxM3RwOW9uMHEyNzVudjQgY19xOXRzZWlnbG9tZHNqNm5qdWh2YnB0czExY0Bn", | ||
| "url": "https://github.com/asyncapi/community/issues/1177", | ||
| "title": "Marketing WG Meeting,", |
There was a problem hiding this comment.
Fix typo in meeting title
Remove the trailing comma from the title "Marketing WG Meeting,".
- "title": "Marketing WG Meeting,",
+ "title": "Marketing WG Meeting",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "title": "Marketing WG Meeting,", | |
| "title": "Marketing WG Meeting", |
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
New Features
Bug Fixes
Documentation