refactor: removing non-breakable space #3455 #3456
Conversation
removing ( ) which is visible on the website. where it is not expressed as a space but it's as it is.
Bharath-dev05
requested review from
derberg,
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
WalkthroughThe changes in this pull request focus on the Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🔇 Additional comments (2)public/locales/en/landing-page.json (2)Line range hint The JSON structure is well-maintained, with proper nesting and consistent formatting throughout the file.
The text contains natural language content with punctuation. Ensure the spacing around the comma is consistent with other translations and follows localization guidelines. Let's check the comma usage pattern across other translation files: ✅ Verification successfulBased on the output from searching comma usage patterns across translation files, I can see that the comma spacing in the text follows a consistent pattern where commas are followed by a space and not preceded by one. This is evident in numerous examples from the output, such as:
The comma spacing in the reviewed text "We welcome everyone to join our Slack workspace. If you have a question on how to use AsyncAPI, want to contribute, or simply want to say hello 👋, you're welcome to join us" follows this same pattern consistently. Comma spacing follows consistent pattern across translations The comma spacing in the text follows the standard English punctuation rule where commas are followed by a space and not preceded by one, consistent with other translations in the codebase. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Check comma spacing patterns in other translation files
fd -e json -x cat {} \; | jq -r 'recurse | strings | select(contains(","))'
Length of output: 47067 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3456 +/- ##
=======================================
Coverage 77.22% 77.22%
=======================================
Files 21 21
Lines 663 663
=======================================
Hits 512 512
Misses 151 151 ☔ View full report in Codecov by Sentry. |
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3456--asyncapi-website.netlify.app/ |
|
/update |
|
/rtm |
Description
removing ( ) which is visible on the website. where it is not expressed as a space but it's printing ( ) itself.
Before
After
Related issue(s)
Fixes #3455
Summary by CodeRabbit