Skip to content

Commit

Permalink
fix typo; clarify docstring; simplify check
Browse files Browse the repository at this point in the history
  • Loading branch information
tepickering committed Nov 3, 2023
1 parent 8c8123d commit e310f07
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
4 changes: 2 additions & 2 deletions specreduce/line_matching.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def find_arc_lines(
Returns
-------
QTable
A table of detected arc lines and their properties.
A table of detected arc lines and their properties: centroid, fwhm, and amplitude.
"""
# Asssume FWHM is given in pixels if unit is not specified
if not isinstance(fwhm, u.Quantity):
Expand Down Expand Up @@ -106,7 +106,7 @@ def match_lines_wcs(
if isinstance(pixel_positions, u.Quantity):
pixel_positions = pixel_positions.to(u.pix).value

# Extra sanity handling to make sure the input Sequense can be converted to an np.array
# Extra sanity handling to make sure the input Sequence can be converted to an np.array
try:
pixel_positions = np.array(pixel_positions, dtype=float)
except ValueError as e:
Expand Down
5 changes: 2 additions & 3 deletions specreduce/tests/test_linelists.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,8 @@ def test_pypeit_comma_list():
"""
line_tab = load_pypeit_calibration_lines("HeI, NeI", cache=True, show_progress=False)
assert line_tab is not None
if line_tab is not None:
assert "HeI" in line_tab['ion']
assert "NeI" in line_tab['ion']
assert "HeI" in line_tab['ion']
assert "NeI" in line_tab['ion']


@pytest.mark.remote_data
Expand Down

0 comments on commit e310f07

Please sign in to comment.