You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is a scope for adding validation around user input and validation on the results of some of the checks we do upfront instead of waiting for the workflow to fail unexpectedly. Some of these scenarios to cover are:
add validation on root-folder, can't have it start with "/", and also can't set it to a non-existent folder
astro deployment inspect commands do not return with exit code 1 if the key does not exist, i.e. in case of deployment is not found in the workspace, so where we are assigning variable values, needs to handle for failure scenarios separately, or we could also update the astro deployment inspect logic to return with exit code 1.
The text was updated successfully, but these errors were encountered:
neel-astro
changed the title
Add upfront validations for user input
Add upfront validations in deploy action
Sep 27, 2024
Description:
There is a scope for adding validation around user input and validation on the results of some of the checks we do upfront instead of waiting for the workflow to fail unexpectedly. Some of these scenarios to cover are:
root-folder
, can't have it start with "/", and also can't set it to a non-existent folderastro deployment inspect
commands do not return with exit code 1 if the key does not exist, i.e. in case of deployment is not found in the workspace, so where we are assigning variable values, needs to handle for failure scenarios separately, or we could also update theastro deployment inspect
logic to return with exit code 1.The text was updated successfully, but these errors were encountered: