Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upfront validations in deploy action #85

Open
neel-astro opened this issue Sep 27, 2024 · 0 comments
Open

Add upfront validations in deploy action #85

neel-astro opened this issue Sep 27, 2024 · 0 comments

Comments

@neel-astro
Copy link
Collaborator

Description:

There is a scope for adding validation around user input and validation on the results of some of the checks we do upfront instead of waiting for the workflow to fail unexpectedly. Some of these scenarios to cover are:

  • add validation on root-folder, can't have it start with "/", and also can't set it to a non-existent folder
  • astro deployment inspect commands do not return with exit code 1 if the key does not exist, i.e. in case of deployment is not found in the workspace, so where we are assigning variable values, needs to handle for failure scenarios separately, or we could also update the astro deployment inspect logic to return with exit code 1.
@neel-astro neel-astro changed the title Add upfront validations for user input Add upfront validations in deploy action Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant