Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retrieving namespace from user-defined YAML config #108

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tatiana
Copy link
Collaborator

@tatiana tatiana commented Dec 2, 2024

If users set the value of ray_cluster_yaml pointing to a RayCluster that would have a namespace, such as:

apiVersion: ray.io/v1
kind: RayCluster
metadata:
  name: airflow-raycluster
  namespace: non-default

And

  workerGroupSpecs:
    template:
      metadata:
        namespace: non-default

The RayCluster was still being created in the "default" namespace, since this value was hard-coded in the provider RayHook.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.55%. Comparing base (c52202a) to head (f0548b3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
+ Coverage   98.52%   98.55%   +0.02%     
==========================================
  Files           7        7              
  Lines         610      622      +12     
==========================================
+ Hits          601      613      +12     
  Misses          9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants