Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added --image-name flag for software, similar to astro #1758

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Added --image-name flag for software, similar to astro #1758

wants to merge 7 commits into from
+207 −71

Conversation

rujhan-arora-astronomer
Copy link
Contributor

@rujhan-arora-astronomer rujhan-arora-astronomer commented Dec 12, 2024 •
edited
Loading

Description

Added --image-name flag for software, similar to astro.
If image-name is set, we tag the passed image with our standard tag instead of building a new image and then the rest of the flow remains the same.
The behaviour is the same as astro.

🎟 Issue(s)

Related https://github.com/astronomer/issues/issues/6828

🧪 Functional Testing

locally

📸 Screenshots

Screenshot 2024-12-12 at 6 19 00 PM Screenshot 2024-12-12 at 6 19 38 PM

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

neel-astro
neel-astro reviewed Dec 12, 2024
View reviewed changes
Copy link
Contributor

@neel-astro neel-astro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor nits, but functionally it looks fine

cmd/software/deploy_test.go Outdated Show resolved Hide resolved
cmd/software/deploy_test.go Show resolved Hide resolved
software/deploy/deploy_test.go Show resolved Hide resolved
software/deploy/deploy_test.go Show resolved Hide resolved
software/deploy/deploy.go Outdated Show resolved Hide resolved
@rujhan-arora-astronomer
1. Split buildPushDockerImage into buildDockerImage(buildDockerImageF…
e4b32ed 
…orWorkingDir and buildDockerImageForCustomImage) and pushDockerImage. 2. Increased test coverage
@rujhan-arora-astronomer
1. Split buildPushDockerImage into buildDockerImage(buildDockerImageF…
1bbd0e3 
…orWorkingDir and buildDockerImageForCustomImage) and pushDockerImage. 2. Increased test coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremybeard jeremybeard Awaiting requested review from jeremybeard jeremybeard is a code owner

@kushalmalani kushalmalani Awaiting requested review from kushalmalani kushalmalani is a code owner

@neel-astro neel-astro Awaiting requested review from neel-astro neel-astro is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rujhan-arora-astronomer @neel-astro