Upgrade golangci-lint to v1.62.2 #1756
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremybeard
requested review from
neel-astro,
kushalmalani and
lzdanski
as code owners
neel-astro
approved these changes
Dec 12, 2024
| @@ -210,8 +210,8 @@ func (d *DockerImage) Pytest(pytestFile, airflowHome, envFile, testHomeDirectory | |||
|
|
|||
| // start pytest container | |||
| err = cmdExec(containerRuntime, stdout, stderr, []string{"start", "astro-pytest", "-a"}...) | |||
| if docErr != nil { | |||
| log.Debugf("Error starting pytest container: %s", docErr.Error()) | |||
| if err != nil { | |||
| @@ -68,15 +68,15 @@ func (rt DockerRuntime) initializeDocker(timeoutSeconds int) error { | |||
| // If we got an error, Docker is not running, so we attempt to start it. | |||
| _, err = rt.Engine.Start() | |||
| if err != nil { | |||
| return fmt.Errorf(dockerOpenNotice) //nolint:stylecheck | |||
| return errors.New(dockerOpenNotice) | |||
There was a problem hiding this comment.
nit: we should stay with fmt.Errorf I think, since pkg/errors is deprecated now, wdyt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change upgrades the golangci-lint dependency to the latest version so that it can support Go 1.23, which the CLI is also upgraded to. The corresponding linting errors are then also fixed.
📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft