Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated all the notebooks and the README file #207

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ragadeepika-Pucha
Copy link
Collaborator

@rnikutta @stephjuneau @jacquesalice - I updated the DESI-related notebooks and the associated ReadMe File:

  • I modified the cell containing the redshift distribution plot to include a for-loop over the targeting classes. I did not want to include a plotting function - because I personally do not like to include functions in the middle of the cell without proper doc-string. I can change it if the current version is not good?
  • I updated my affiliation and contact information.
  • I added the authentication cell to the DESI-EDR with DESI kernel and DESI/SDSS comparison notebooks, to be consistent with the DESI-EDR Py3 notebook.
  • I added a bullet regarding the Py3 notebook in the ReadMe file.

Let me know if anything else needs to be updated/changed.
Thank you!

Copy link
Member

@jacquesalice jacquesalice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Ragadeepika-Pucha , I think it all looks good! Only one small suggested addition to the README :-)

@@ -6,6 +6,8 @@ The Astro Data Lab includes a collection of notebooks showcasing the DESI data.

- `01_Intro_to_DESI_EDR.ipynb` shows how to access the redshift catalog from the Astro Data Lab database, how to separate objects based on the DESI targeting information, how to access all the available spectra for a given object using [SPARCL (SPectra Analysis and Retrievable Catalog Lab)](https://astrosparcl.datalab.noirlab.edu), and finally how to plot the "best" spectrum.

- `01a_Intro_to_DESI_EDR-Py3.ipynb` is similar to the previous notebook, but installing the DESI software is not required to run this notebook. It uses the Python 3 kernel and shows how to access the DESI EDR redshift catalog from the Astro Data Lab database, how to select sources based on the DESI targeting information, and how to access and plot the required spectra using SPARCL.

- `02_DESI_EDR_SDSS_Comparison.ipynb` shows how to use SPARCL data discovery to find available SDSS DR16 and DESI EDR spectra of sources in a specific region of the sky with redshift and spectype constraints, how to retrieve and compare spectra for the same galaxy observed with both SDSS and DESI.

## How-to folder: `04_HowTos/`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to also add the SPARCL/Plot_SPARCL_Spectra_with_Prospect.ipynb notebook here? It plots some DESI EDR spectra with Prospect

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ragadeepika-Pucha @stephjuneau Hi, what's the status of this PR? Thanks.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce a function for plotting z histograms in DESI EDR notebooks
3 participants