Upgrade specutils and astropy dependencies for python > 3.10
#72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
|
||
| # astropy changed stuff with the votable in version 6.0.0 | ||
| # https://github.com/astropy/astropy/blob/main/CHANGES.rst#astropyiovotable-3 | ||
| if astropy.__version__ >= '6.0.0': |
There was a problem hiding this comment.
Hi ! Astropy dev here.
Note that comparing version strings directly doesn't work as you'd expect and is not recommended
>>> '10.0.0' > '2.0.0'
FalseFortunately, astropy provides a more robust way to implement this:
using
from astropy.utils import minversion
ASTROPY_GE_6_0 = minversion("astropy", "6.0.0")you can rewrite this conditional as
Suggested change
| if astropy.__version__ >= '6.0.0': | |
| if ASTROPY_GE_6_0: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi datalab core developers!
I am working on a package and want to use the datalab queryClient but have been finding the astropy requirements to be too strict for my use case. For example, the astropy affiliated
synphotpackage requiresastropy >= 6.1while the datalab package couldn't haveastropy>=5.4.I investigated this a little and I think the reasons for these constraints was because astropy changed their API for the VOTable so the tests for the helper.util.convert method were failing and because the
specutilswas not allowingastropy>6until recently. After installing the newer version of specutils and astropy and fixing the test cases for this package I think everything still appears stable (at least all of the unit tests pass and my code using thequeryClientworks still!).But, I know I may be missing something here for why the astropy version requirement was so strict previously. I look forward to your feedback and working with you on this!