Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up names in Bundle API #1888

Open
itamarreif opened this issue Jan 2, 2025 · 0 comments · May be fixed by #1889
Open

Clean up names in Bundle API #1888

itamarreif opened this issue Jan 2, 2025 · 0 comments · May be fixed by #1889
Labels
auctioneer

Comments

@itamarreif
Copy link
Contributor

itamarreif commented Jan 2, 2025 •
edited by sync-by-unito bot
Loading

The current Bundle stream API is badly named:

  1. The Bundles as they are currently named (in the astria.bundle.v1alpha protos) are in fact bids for the auctioneer. This object should be renamed to Bid.
  2. What is currently the astria.bundle package should be renamed to astria.auction (or something similar) and these should be referred to as the Auction APIs.

The "Bundle API" should be the name for the user-facing interface for submitting bundles. The Bundle object name should be reserved for this bundle ingestion api that will replace the auctioneer's rollup-side mempool soon after the MVP.

┆Issue Number: ENG-1056
@itamarreif itamarreif changed the title Rename bundle api to auction api and bundle to bid Clean up names in Bundle API Jan 2, 2025
@itamarreif itamarreif linked a pull request Jan 2, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auctioneer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(auctioneer, protos): rename bundle apis astriaorg/astria
1 participant
@itamarreif