chore(conductor): send boxed objects over channels #1865
Merged
+27
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanoroshiba
added
conductor
|
Interesting that this showed up now - I remember clippy flagging this at some point, and I was almost certain that I did add an exception attribute, but maybe I am hallucinating. Instead of boxing the problematic error variant, can you change the mpsc channel to be |
|
Neither PR text nor PR title match what the changes. |
ethanoroshiba
changed the title
SuperFluffy
changed the title
SuperFluffy
reviewed
Jan 6, 2025
SuperFluffy
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changed firm block channel to use boxed
ReconstructedBlock.Background
A large error variant lint was triggered when running clippy with Rust 1.83.0 in #1857 due to send errors returning the whole block. Large enum variants should be avoided because enums are only as small as their largest variant: https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant. Changing the channel to consist of a boxed block instead solves this problem at its source.
Changes
ReconstructedBlockinstead of it being unboxed.Testing
Passing all tests.
Changelogs
No updates needed.
Breaking Changes
Overridden code freeze since this is a very small, non breaking change that shouldn't have any bearing since our previous audit.
Related Issues
closes #1858