chore(composer): propagate errors #1838
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanoroshiba
changed the base branch from
main
to
ENG-914/composer_blackbox_tests
ethanoroshiba
force-pushed
the
ENG-1026/propagate_composer_errors
branch
from
c32105a to
d179b70
Compare
ethanoroshiba
force-pushed
the
ENG-1026/propagate_composer_errors
branch
from
d179b70 to
0801687
Compare
SuperFluffy
reviewed
Jan 6, 2025
|
Left a bunch of comments. This does not seem to be a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Propagate errors which occur while composer is starting up and/or running so that the will be returned by the Composer's handle.
Background
Previously, composer would only exit with an error if the collectors' or executor's status channels were closed, and then the error message did not provide detailed information about the error that occurred. Additionally, if either of the
wait_for_*loops failed, the composer would not shut down gracefully. This change is meant to expose the first eyre report which causes the composer to shut down, and gracefully shut down in all circumstances.Changes
wait_for_readyloops concurrently, and continue with graceful shutdown even if these fail.Testing
Passing all tests
Changelogs
Changelog updated
Related Issues
closes #1833