Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Share our testing fixtures efficiently #138

Open
2 tasks
akhercha opened this issue Jul 7, 2024 · 0 comments
Open
2 tasks

test: Share our testing fixtures efficiently #138

akhercha opened this issue Jul 7, 2024 · 0 comments

Comments

@akhercha
Copy link
Member

akhercha commented Jul 7, 2024

Feature Request

Current behavior

We currently have a lot of duplicated test code (fixtures mainly) between our tests for pragma-sdk, price-pusher and vrf-listener and checkpoint-setter.

Expected behavior

We want to create a new pragma-testing poetry package that will be a pytest plugin holding every fixtures that can be shared across tests.
The different packages will then just import this package and use the fixtures.

EDIT: Creating a new pragma-testing package won't be possible as it will create a lot of circular dependencies (the fixtures that we want to use uses pragma-sdk).

Instead, we want to organize our fixtures better directly in the pragma-sdk package and allows the others packages to just import them as a pytest plugin.

Improvements

  • Use testcontainer to start devnet-rs (image)
  • Use the new DevnetClient from starknet.py
@akhercha akhercha changed the title dev: Create the pragma-testing package dev: Share our testing fixtures efficiently Jul 17, 2024
@EvolveArt EvolveArt moved this to Todo in Pragma Backlog Jul 18, 2024
@akhercha akhercha changed the title dev: Share our testing fixtures efficiently test: Share our testing fixtures efficiently Jul 20, 2024
@akhercha akhercha removed their assignment Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant