Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Update typed_data following the starknet.py hash update #87

Open
akhercha opened this issue Jul 18, 2024 · 0 comments
Open

perf: Update typed_data following the starknet.py hash update #87

akhercha opened this issue Jul 18, 2024 · 0 comments

Comments

@akhercha
Copy link
Member

akhercha commented Jul 18, 2024

Current behavior

We currently verify for signatures correctness using the Pedersen hash. This costs us a lot of time in our pragma-sdk publishing so we want to update to Poseidon, which is now possible in the new starknet.py release.

Expected behavior

Sync with this issue:
astraly-labs/pragma-sdk#151

And update the typed_data module so it works correctly with the new changes:
https://github.com/astraly-labs/pragma-node/blob/main/pragma-node/src/utils/signing/typed_data.rs

This will mainly be update the revision field to 1 and check if the use of compute_hash_on_elements still fits our usecase - else, change this hash

@akhercha akhercha changed the title perf: Update typed_data following the starknet.py update perf: Update typed_data following the starknet.py hash update Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant