You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We currently verify for signatures correctness using the Pedersen hash. This costs us a lot of time in our pragma-sdk publishing so we want to update to Poseidon, which is now possible in the new starknet.py release.
akhercha
changed the title
perf: Update typed_data following the starknet.py update
perf: Update typed_data following the starknet.py hash update
Jul 18, 2024
Current behavior
We currently verify for signatures correctness using the
Pedersen
hash. This costs us a lot of time in ourpragma-sdk
publishing so we want to update toPoseidon
, which is now possible in the newstarknet.py
release.Expected behavior
Sync with this issue:
astraly-labs/pragma-sdk#151
And update the
typed_data
module so it works correctly with the new changes:https://github.com/astraly-labs/pragma-node/blob/main/pragma-node/src/utils/signing/typed_data.rs
This will mainly be update the revision field to 1 and check if the use of
compute_hash_on_elements
still fits our usecase - else, change this hashThe text was updated successfully, but these errors were encountered: