Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: Update naive timestamps with UTC timezones #44

Open
akhercha opened this issue May 30, 2024 · 1 comment · Fixed by #46
Open

dev: Update naive timestamps with UTC timezones #44

akhercha opened this issue May 30, 2024 · 1 comment · Fixed by #46

Comments

@akhercha
Copy link
Member

akhercha commented May 30, 2024

Current Behavior

Currently, we store timestamps without any timezone information. This is a bad practice as it could lead to wrong interpretations at later stages.

Expected Behavior

  • The timestamps in our databases should have TZ info
  • The rust code should fetch timestamps as DateTime instead of NaiveDateTime
  • E2E tests are added so we're sure everything works fine
@akhercha akhercha changed the title dev: Update naive timestamps to UTC timezones dev: Update naive timestamps with UTC timezones May 30, 2024
@akhercha akhercha reopened this Jun 5, 2024
@akhercha
Copy link
Member Author

akhercha commented Jun 5, 2024

Changes reverted in

Those caused new entries to not be published & we had TimeSinceLastUpdateTooHigh alerts (causing WrongPrice alerts later).

Labels:
 - alertname = TimeSinceLastUpdateTooHigh
 - group = API
  - job = prometheus_monitoring
 - network = Testnet
 - pair = BTC/USD
 - severity = warning
Annotations:
 - description = The time since the last update for BTC/USD has exceeded 1800 seconds.
 - summary = Time since the last update is too high
Labels:
 - alertname = TimeSinceLastUpdateTooHigh
 - group = API
 - job = prometheus_monitoring
 - network = Testnet
 - pair = DAI/USD
 - severity = warning
Annotations:
 - description = The time since the last update for DAI/USD has exceeded 1800 seconds.
 - summary = Time since the last update is too high
Labels:
 - alertname = TimeSinceLastUpdateTooHigh
 - group = API
 - job = prometheus_monitoring
 - network = Testnet
 - pair = ETH/USD
 - severity = warning
Annotations:
 - description = The time since the last update for ETH/USD has exceeded 1800 seconds.
 - summary = Time since the last update is too high
Labels:
 - alertname = TimeSinceLastUpdateTooHigh
 - group = API
 - job = prometheus_monitoring
 - network = Testnet
 - pair = USDC/USD
 - severity = warning
Annotations:
 - description = The time since the last update for USDC/USD has exceeded 1800 seconds.
 - summary = Time since the last update is too high
Labels:
 - alertname = TimeSinceLastUpdateTooHigh
 - group = API
 - job = prometheus_monitoring
 - network = Testnet
 - pair = USDT/USD
 - severity = warning
Annotations:
 - description = The time since the last update for USDT/USD has exceeded 1800 seconds.
 - summary = Time since the last update is too high
Labels:
 - alertname = SourceDeviation
 - job = prometheus_monitoring
 - network = Testnet
 - pair = BTC/USD
 - severity = warning
 - source = BINANCE
 - type = future
Annotations:
 - description = The source deviation of BTC/USD from BINANCE has exceeded 2%.
 - summary = Source deviation is too high
Labels:
 - alertname = WrongPrice
 - job = prometheus_monitoring
 - network = Testnet
 - pair = BTC/USD
 - severity = warning
 - source = BINANCE
 - type = future
Annotations:
 - description = The price deviation of BTC/USD from BINANCE has exceeded 2.5%.
 - summary = Price deviation is too high

We reverted those changes and now everything works correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant