Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace packages are skipped in uv sync --only-group [group] #9383

Open
charliermarsh opened this issue Nov 23, 2024 · 4 comments · May be fixed by #9385
Open

Workspace packages are skipped in uv sync --only-group [group] #9383

charliermarsh opened this issue Nov 23, 2024 · 4 comments · May be fixed by #9385
Assignees
Labels
bug Something isn't working

Comments

@charliermarsh
Copy link
Member

If the workspace package is in [group], it should still be installed.

@charliermarsh charliermarsh added bug Something isn't working needs-mre Needs more information for reproduction labels Nov 23, 2024
@charliermarsh
Copy link
Member Author

(I haven't tested this, but it was reported on Discord.)

@charliermarsh charliermarsh removed the bug Something isn't working label Nov 23, 2024
@charliermarsh
Copy link
Member Author

I think we handle this correctly?

@charliermarsh
Copy link
Member Author

It look like the case we don't handle is this:

[project]
name = "htmst"
version = "0.0.0"
readme = "README.md"
description = "HTML to AST"
authors = [{ name = "Al Mahdi", email = "[email protected]" }]
license = { text = "MIT" }
classifiers = [
  "Intended Audience :: Developers",
  "License :: OSI Approved :: MIT License",
  "Programming Language :: Python :: 3",
  "Programming Language :: Python :: 3.12",
  "Programming Language :: Python :: 3.13",
  "Typing :: Typed",
]
requires-python = ">=3.12"
dependencies = []

[dependency-groups]
test = ["htmst", "pytest==8.3.3"]
dev = ["pre-commit==4.0.1", "pytest-watcher==0.4.3", "ruff==0.8.0"]

@srosen -- sorry to ping, but is this allowed in PEP 735? For a group to reference the project itself? (I know a project isn't guaranteed to exist in this context, but it does here.)

@charliermarsh
Copy link
Member Author

As far as I can tell from the spec, this is allowed, despite this section: https://peps.python.org/pep-0735/#why-not-support-a-dependency-group-which-includes-the-current-project. It's a bit strange, since you could also reference the current package with extras enabled.

@charliermarsh charliermarsh self-assigned this Nov 23, 2024
@charliermarsh charliermarsh added bug Something isn't working and removed needs-mre Needs more information for reproduction labels Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant