Skip to content
This repository has been archived by the owner on Feb 16, 2024. It is now read-only.

Can I cancel the use of vendor folder? Or allow the caller to customize the storage path #395

Open
peakedshout opened this issue Oct 9, 2023 · 3 comments

Comments

@peakedshout
Copy link

Obviously, the vendor folder has special meaning in Go. When debugging locally, the generated vendor will make the project reference the code library of this folder by default. I don't want to do this. Maybe you will say modify the DataDirectoryPath, but for me, fetching resources should be "./"
github.com/asticode/go-astilectron/paths.go:56 Maybe I can force changes to use it, but I don't think it's a good coding practice, once modified, the project will also carry the vendor, and if you forget to change it again when updating dependencies in the future, it will be bad
I like this project, cheers

@asticode
Copy link
Owner

asticode commented Oct 9, 2023

Right now you can't customize the vendor directory path.

However that could be added to this lib with a VendorDirectoryPath option like here.

I'm welcoming PRs ❤️

@peakedshout
Copy link
Author

Are you considering supporting more free customization? I tried to modify it and found that it works, it seems to be just a storage path, and there is no special meaning (please correct me if my idea is wrong)

@asticode
Copy link
Owner

You can submit a PR and we can go from here 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants