Skip to content
This repository has been archived by the owner on Dec 29, 2021. It is now read-only.

What should the name be for Assert::example #110

Closed
epage opened this issue May 25, 2018 · 3 comments
Closed

What should the name be for Assert::example #110

epage opened this issue May 25, 2018 · 3 comments
Labels

Comments

@epage
Copy link
Collaborator

epage commented May 25, 2018

#108 added Assert::example.

We now have

  • main_binary for running cargo run
  • cargo_binary for running cargo run --bin <name>
  • example for running cargo run --example <name>

Should example also be cargo_example?

CC @volks73 @azriel91

@epage epage added the question label May 25, 2018
@epage
Copy link
Collaborator Author

epage commented May 25, 2018

Noticed this when adding a test for Assert:example

@volks73
Copy link
Contributor

volks73 commented May 25, 2018

I originally had example_binary but that seemed redundant/confusing, so I shortened it to just example as I figured the usage of Cargo was implied.

The cargo_example works for me and is more consistent with the other function, especially given #111, where the usage of Cargo is no longer implied. The prepended "cargo" would indicate to users that the cargo command will be used.

@epage
Copy link
Collaborator Author

epage commented May 29, 2018

Addressed in assert_cmd
https://github.com/assert-rs/assert_cmd
assert_cli is going to morph into a wider-focused tool, including things like assert_fs. See #41

@epage epage closed this as completed May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants