Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MinGW fails to compile due to warnings #247

Open
asmaloney opened this issue Apr 21, 2023 · 2 comments
Open

MinGW fails to compile due to warnings #247

asmaloney opened this issue Apr 21, 2023 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@asmaloney
Copy link
Owner

asmaloney commented Apr 21, 2023

(From here: #245 (comment))

I think his fix in CRCpp (which is what I used here) won't work for MinGW.

@UshnaGul - can you try changing the checks in CheckedFile.cpp from

#if defined( WIN32 ) || defined( _WIN32 ) || defined( WINCE )

to

#if defined( _MSC_VER )

That should turn off the pragmas MinGW doesn't understand. Not sure if it will throw other errors though.

@asmaloney asmaloney added the bug Something isn't working label Apr 21, 2023
@UshnaGul
Copy link

I did that and it appears to be fixed. But I did the same thing in another place as I had a similar error and now I am running into more issues:
image
E57SimpleData.cpp:
image

Errors:
undefined reference to `e57::Data3DPointsData_t::Data3DPointsData_t(e57::Data3D&)'
image

@asmaloney asmaloney changed the title Disabling CRCpp warnings fails when compiling with MinGW MinGW fails to compile due to warnings Apr 21, 2023
@asmaloney
Copy link
Owner Author

I don't know how to fix this since I can't compile with MinGW and it seems like it's a bigger problem (whac-a-mole!).

I'll check in a couple of fixes and leave this issue open in case someone with MinGW wants to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants