Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E57SimpleReader: Improve data setup #160

Closed
asmaloney opened this issue Nov 2, 2022 · 1 comment
Closed

E57SimpleReader: Improve data setup #160

asmaloney opened this issue Nov 2, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@asmaloney
Copy link
Owner

asmaloney commented Nov 2, 2022 •
edited
Loading

Setting up data is confusing. Not only do we have the scaled integer problem, but if the user:

  • sets pointRangeScaledInteger but does not set pointRangeMinimum and pointRangeMaximum OR
  • sets intensityField but does not set intensityMinimum and intensityMaximum OR
  • sets timeStampField but not timeMinimum and timeMaximum
  • (There are probably more cases like this.)

It results in a runtime exception. Writing this setup code is very much trial-and-error and the resulting exceptions don't directly point to the problem. This is not very good UX.

We should consider adding a function (finalizeData() or something) to set things up automatically based on what's in the Data3D, its pointFields, and the Data3DPointsData_t.
@asmaloney asmaloney added the enhancement New feature or request label Nov 2, 2022
@asmaloney asmaloney mentioned this issue Nov 10, 2022
Merged
asmaloney added a commit that referenced this issue Nov 14, 2022
@asmaloney
E57Simple: Simplify & clarify node types when setting up Data3D
6f24496 
Note that Data3D's "intensity" has been changed to a double so we can allow writing them as doubles.

Addresses some of #157 and #160
asmaloney added a commit that referenced this issue Nov 22, 2022
@asmaloney
E57Simple: Simplify & clarify node types when setting up Data3D (#178)
0c8cbd5 
Note that Data3D's "intensity" has been changed to a double so we can allow writing them as doubles.

Addresses some of #157 and #160
@asmaloney
Copy link
Owner Author

Much improved by #175 and #178, so closing this issue.

If any specific issues come up they can be filed separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@asmaloney