Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about generating new data, does splits/oct21.json need to be changed? #132

Open
Samuel-Fipps opened this issue Jan 28, 2023 · 1 comment
Labels
question Further information is requested

Comments

@Samuel-Fipps
Copy link

Hello,

I'm just generating more data with generate_trajectories.py, I was just wondering if the splits/oct21.json file needed to be changed in anyway to include this new data.

Sorry if this is mentioned somewhere else, I tired to look around for the answer the best I could.

@Samuel-Fipps Samuel-Fipps changed the title When generating new data, does splits/oct21.json need to be changed? Question about generating new data, does splits/oct21.json need to be changed? Jan 28, 2023
@MohitShridhar
Copy link
Collaborator

@Samuel-Fipps, apologies for the late reply.

Just avoid generating data in test rooms. splits/oct21.json is specific to the ALFRED dataset. If you use generate_trajectories.py to generate another dataset you will get a new train and val distribution different from the ALFRED dataset.

@MohitShridhar MohitShridhar added the question Further information is requested label Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants