Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs endpoint error #32

Open
piferrari opened this issue Jun 2, 2021 · 3 comments
Open

Logs endpoint error #32

piferrari opened this issue Jun 2, 2021 · 3 comments

Comments

@piferrari
Copy link

Hi,

In Containers.php (line 504) and Containers/Logs.php (line 26) you have two time the same error:

        foreach ($this->get($this->getEndpoint().$name.'/logs/') as $log) {
            $logs[] = str_replace(
                '/'.$this->client->getApiVersion().'/containers/'.$name.'/logs/',
                '',
                $log
            );
        }

You must replace /containers/ by /instances/

Best Regards

PiF

@piferrari
Copy link
Author

piferrari commented May 13, 2022 via email

@C0rn3j
Copy link

C0rn3j commented Nov 19, 2023

Well this is somewhat of a dupe of #34 as switching /containers/ to /instances/ fixes it.

@ashleyhood Do you have an interest in maintaining this project still? I could send a PR if so.

It's been broken for VMs for some time and a fork has popped up - https://github.com/turtle0x1/php-lxd

(I also forked it with just the VM fixes so far)

@ashleyhood
Copy link
Owner

Thanks @C0rn3j for you r offer of a PR but I don't use this library anymore and so don't have time to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants