-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new metadata properties. #198
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add version, weather_model, temporal_baseline_days, frame_number.
jtherrmann
force-pushed
the
update-metadata-schema
branch
from
April 14, 2023 17:32
3050008
to
0d6281a
Compare
jtherrmann
commented
Apr 17, 2023
asjohnston-asf
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
version
,weather_model
,temporal_baseline_days
,frame_number
.TODO:
version
include any validation to ensure it's a valid version number?version
requiredtemporal_baseline_days
have a minimum value of6
? (see https://github.com/ACCESS-Cloud-Based-InSAR/DockerizedTopsApp/pull/102/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR28)frame_number
allow a value of-1
? (see Update metadata withframe_id
,version
andtemporal_baseline_days
ACCESS-Cloud-Based-InSAR/DockerizedTopsApp#102)weather_model
looks like