From d7979c111ef80f77d1e04b1f49538f8946fe8f5f Mon Sep 17 00:00:00 2001 From: Thomas Fransham Date: Tue, 5 Nov 2024 14:32:52 +0000 Subject: [PATCH] [Clang][TableGen] Add explicit symbol visibility macros to code generated (#109362) Update ClangAttrEmitter TableGen to add explicit symbol visibility macros to attribute class declarations it creates. Both AnnotateFunctions and Attribute example plugins require clang::AnnotateAttr TableGen created functions to be exported from the Clang shared library. This depends on macros to be added in https://github.com/llvm/llvm-project/pull/108276 --- clang/utils/TableGen/ClangAttrEmitter.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/clang/utils/TableGen/ClangAttrEmitter.cpp b/clang/utils/TableGen/ClangAttrEmitter.cpp index 3031d81b3df731..5a80c8c0b7ad36 100644 --- a/clang/utils/TableGen/ClangAttrEmitter.cpp +++ b/clang/utils/TableGen/ClangAttrEmitter.cpp @@ -2727,7 +2727,8 @@ static void emitAttributes(const RecordKeeper &Records, raw_ostream &OS, } if (Header) - OS << "class " << R.getName() << "Attr : public " << SuperName << " {\n"; + OS << "class CLANG_ABI " << R.getName() << "Attr : public " << SuperName + << " {\n"; else OS << "\n// " << R.getName() << "Attr implementation\n\n"; @@ -3185,7 +3186,8 @@ void clang::EmitClangAttrClass(const RecordKeeper &Records, raw_ostream &OS) { emitSourceFileHeader("Attribute classes' definitions", OS, Records); OS << "#ifndef LLVM_CLANG_ATTR_CLASSES_INC\n"; - OS << "#define LLVM_CLANG_ATTR_CLASSES_INC\n\n"; + OS << "#define LLVM_CLANG_ATTR_CLASSES_INC\n"; + OS << "#include \"clang/Support/Compiler.h\"\n\n"; emitAttributes(Records, OS, true);